Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1913 remove sta_?.T #1914

Closed
wants to merge 9 commits into from
Closed

Issue1913 remove sta_?.T #1914

wants to merge 9 commits into from

Conversation

hcasperfu
Copy link
Contributor

@hcasperfu hcasperfu commented Aug 6, 2024

This closes #1913.
The models that have sta_?.T in their reference results:

  • Fluid.HeatExchangers.Radiators.Examples.RadiatorEN442_2
  • Fluid.FixedResistances.Validation.LosslessPipe
  • Examples.{SimpleHouse,Tutorial.SimpleHouse.SimpleHouse6}
    • Added TemperatureTwoPort components to replace sta_?.T.
  • Fluid.Interfaces.Examples.{PrescribedOutlet,PrescribedOutlet_TSetOnly,PrescribedOutlet_Water,PrescribedOutlet_X_wSetOnly}
    • Added TemperatureTwoPort to base class IBPSA.Fluid.Interfaces.Examples.BaseClasses.PrescribedOutletState.
  • Fluid.SolarCollectors.Validation.{EN12975_Array,EN12975_Series}
  • Fluid.Humidifiers.Validation.{SteamHumidifier_X_dynamic,SprayAirWasher_X,SteamHumidifier_X,SprayAirWasher_X_dynamic}
  • Fluid.Interfaces.Examples.{ConservationEquation,StaticTwoPortConservationEquation}
  • Fluid.Interfaces.Examples.Humidifier_u
    • No action. Flow rate is constant.
  • Fluid.Geothermal.Borefields.Examples.RectangularBorefield
    • No action because allowFlowReversal==false.

@hcasperfu hcasperfu requested a review from mwetter August 6, 2024 02:38
@hcasperfu hcasperfu self-assigned this Aug 6, 2024
@hcasperfu hcasperfu changed the title Issue1983 remove sta_?.T Issue1913 remove sta_?.T Aug 6, 2024
@hcasperfu hcasperfu closed this Aug 6, 2024
@hcasperfu hcasperfu deleted the issue1983_removeStaT branch August 6, 2024 16:34
@hcasperfu
Copy link
Contributor Author

PR reopened as #1918 after correcting branch name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove or replace sta_?.T from reference results
1 participant